Open glenda-tn opened 2 years ago
All the anchors were removed from the listed glyph so it will be not longer added to GDEF. I still need to remove the anchor from /tonos.cap but I don’t want to overwrite any changes being made now.
feel free to make change, i can dive in tomorrow morning
Done 4c27e63
⚠️ WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
These have reappeared: 🔥 FAIL The following non-mark characters should not be in the GDEF mark glyph class:
@guidoferreyra could you perhaps help me with this? I thought these could be spaced and have anchors, and would be set to zero width on build? sorry for the confusion.
The glyph list posted by Glenda are polytonic greek diacritics which are not considered non-spacing and should not be on the GDEF mark class. To prevent fontmake to add it to the GDEF is needed to remove the anchors from it which might not be possible if the anchors are being used to align diacriticis on composite glyphs.
A solution is to add duplicate glyph components, unencoded, and classify the duplicate as a mark. Note the dupe would be on zero width while the encoded glyph remains spacing. The substitution takes place in `ccmp' very early in processing. I used this solution many times in the past.
Following up on this: Adding duplicates as suggested above increases the complexity of the font, and we are hesitant to do something that creates mores issues than it solves. Since this is a fontbakery WARN and not a FAIL, we will let this stand unless otherwise requested.
The following non-mark characters (spacing marks) should not be in the GDEF mark glyph class:
The above code points are all defined as spacing marks in Unicode. To use as non-spacing marks, create a duplicate component set on zero width.