search

canonical / Ubuntu-Sans-fonts

Other
54 stars 4 forks source link

All marks should be classified in GDEF mark class #26

Open glenda-tn opened 2 years ago

glenda-tn commented 2 years ago

The following mark characters could be in the GDEF mark glyph class:

guidoferreyra commented 1 year ago

All marks are now on GDEF mark class, except for uni0328 (ogonekcomb) because for creating GDEF data fontmake uses anchors in glyphs. ogonekcomb has _ogonek anchor which its seems is being ignored by fontmake. I will create an issue at their repo to get more info, but this is a minor issue.

djrrb commented 1 year ago

@guidoferreyra do you know the status on this, and if it’s worth keeping this issue open?

guidoferreyra commented 1 year ago

All glyphs except for /ogonekcomb are in the GDEF class. I reported the issue https://github.com/googlefonts/fontmake/issues/960 This is a minor thing, but can we keep it open for a few days more?

djrrb commented 1 year ago

that's fine...appreciate you linking to the issue so I didn’t have to go through all 222 open ones 😆

glenda-tn commented 1 year ago

I just came here to report on the current results. I read the thread and understand about uni0328/ogonekcomb.

However, uni0323, the dotbelow, could/should be in the GDEF.

⚠️ WARN

UbuntuCondensed-Bold.ttf
UbuntuCondensed-Regular.ttf
UbuntuCondensed-Thin.ttf
UbuntuCondensed-ExtraBold.ttf
Ubuntu-Medium.ttf
Ubuntu-Thin.ttf
Ubuntu-LightItalic.ttf
Ubuntu-Regular.ttf
Ubuntu-Bold.ttf
Ubuntu-ExtraBold.ttf
Ubuntu-Light.ttf

The following mark characters could be in the GDEF mark glyph class: 
uni0323 (U+0323) [code: mark-chars]
guidoferreyra commented 1 year ago

This issue was addressed on the roman file. Italics still need to be "auto aligned" so better to wait for that.