canonical / Ubuntu-Sans-fonts

Other
54 stars 4 forks source link

Remove PUA codepoints from glyphs. #65

Closed guidoferreyra closed 1 year ago

guidoferreyra commented 1 year ago

Many glyphs are using PUA codepoints, we should remove it and double check are accesible through features.

djrrb commented 1 year ago

I agree we should put them in features and make sure the correct codepoints are used when possible, but I do hesitate to break backwards compatibility unless you think it’s required. @guidoferreyra can you confirm?

To have a record of the glyphs currently using PUA:

Fractions

Only two of these have proper encodings. The frac feature handles other arbitrary fractions. Should we leave these using PUA?

Ligatures

Proportional figures

Implemented via OpenType feature pnum, no encoding necessary. (Will also rename glyph name suffix to '.lf' for clarity.)

Superiors and Inferiors

Use unicode subscripts and superscripts instead or in addition.

Logos

Omitting from font.

guidoferreyra commented 1 year ago

The font has other "breaking" changes to already consider it as new major release, so my opinion is the following:

Fractions: I don’t see what is the point of having those precomposed glyphs for very rare fractions. But if we need to keep them I think it’s better to remove the PUA to not alter user’s character string when activating the feature.

Ligatures: I agree

Proportional figures: I agree. +1 for the renaming too

Superiors and Inferiors. To me just using the superior and inferior unicode values will be enough, no need to add PUA

djrrb commented 1 year ago

Ok sounds like a good plan, I will implement this shortly.

djrrb commented 1 year ago

Changed in e16eed91024b8f645f306c2ac6e17ee5307ea784

It’s a bit unusual because the encoded zerosuperior was set to the numr feature and the unencoded zero.sups is set to the sups feature. But I don‘t see a problem with that.