canonical / Ubuntu-Sans-fonts

Other
55 stars 4 forks source link

unreachables #74

Closed glenda-tn closed 1 year ago

glenda-tn commented 1 year ago

In various styles the following are reported as unreachable:

Currently f_i and f_l are encoded to FB01 and FB02, respectively. It should be the reverse: fi and fl should be encoded. Alternatively, remove the duplicate and keep the fi and fl names. From GlyphsApp:

You may have noticed that fi and fl do not adhere to the naming convention we mentioned above. That’s because they are historical exceptions. These two glyph names were there long before OpenType. Actually, you can still call them f_i and f_l if you want, but again, they’ll go into dlig unless you add the .liga suffix.

I assume the others are components and should be fine. If unused, they can be set to not export.

djrrb commented 1 year ago

These components are used.

Just making sure it’s cool to have the liga feature subbing in the encoded fi and fl glyphs if I remove the underscored ones?

glenda-tn commented 1 year ago

Yes to the above.

Apparently revcommaaccent can be encoded to 0312. ?

guidoferreyra commented 1 year ago

I removed revcommaaccent it was partially unused. commaturnedabovecob (U+0312) was already on the font

guidoferreyra commented 1 year ago

Just making sure it’s cool to have the liga feature subbing in the encoded fi and fl glyphs if I remove the underscored ones?

ligafeature uses /f_i and /f_l and I kept the encoded ligatures (/fi and /fl) for legacy support.

I don’t se a problem of keeping vertical caron (uni030C.alt) unreacheable since is used as a component.

The only other unreacheables are the fractions that are not inclujded by Unicode. To me those glyphs could be deleted since the contextual frac feature already cover the cases

djrrb commented 1 year ago

Unencoded fractions removed in 899b437a9f263bf994491075400bb915c312df9a