canonical / Ubuntu-Sans-fonts

Other
54 stars 4 forks source link

[Google Fonts specific] Check a font's STAT table contains compulsory Axis Values. #96

Closed guidoferreyra closed 1 year ago

guidoferreyra commented 1 year ago

Check ID: <FontBakeryCheck:com.google.fonts/check/STAT> πŸ”₯ fonts/variable/Ubuntu-Italic[wdth,wght].ttf

πŸ”₯ FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Normal wdth 100.0 2 None 100.0 2 None
Condensed wdth 75.0 0 None 75.0 0 None
SemiCondensed wdth N/A N/A N/A 87.5 0 None
Thin wght 100.0 0 None 100.0 0 None
ExtraLight wght N/A N/A N/A 200.0 0 None
Light wght 300.0 0 None 300.0 0 None
Regular wght 400.0 2 700.0 400.0 2 700.0
Medium wght 500.0 0 None 500.0 0 None
SemiBold wght N/A N/A N/A 600.0 0 None
Bold wght 700.0 0 None 700.0 0 None
ExtraBold wght 800.0 0 None 800.0 0 None
djrrb commented 1 year ago

Related to #97...SemiCondensed, ExtraLight, and SemiBold were not in the original family and don’t seem strictly necessary now, but I’m not going to put up a fight if folks want them added.

m4rc1e commented 1 year ago

Please add them

djrrb commented 1 year ago

Added in 0f018d1c0f44c2813e67c4abcccd1ccd159cf437. No longer reported by fontbakery.

🍞 PASS: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)

Check a font's STAT table contains compulsory Axis Values which exist in the Google Fonts Axis Registry.

We cannot determine what Axis Values the user will set for axes such as opsz, GRAD since these axes are unique for each font so we'll skip them.

  • 🍞 PASS Compulsory STAT Axis Values are correct.
m4rc1e commented 1 year ago

Perfect. Thank you very much!