[Google Fonts specific] Check variable font instances

[guidoferreyra]

Check ID: <FontBakeryCheck:com.google.fonts/check/fvar_instances> 🔥 fonts/variable/Ubuntu-Italic[wdth,wght].ttf 🔥 fonts/variable/Ubuntu[wdth,wght].ttf

🔥 FAIL

fvar instances are incorrect:
    Add missing instances
    Delete additional instances

Name	current	expected
Condensed Thin	wdth=75.0, wght=100.0	N/A
Condensed ExtraBold	wdth=75.0, wght=800.0	N/A
Condensed Light	wdth=75.0, wght=300.0	N/A
Condensed Regular	wdth=75.0, wght=400.0	N/A
Condensed Medium	wdth=75.0, wght=500.0	N/A
Condensed Bold	wdth=75.0, wght=700.0	N/A
Thin	wdth=100.0, wght=100.0	wdth=100.0, wght=100.0
ExtraLight	N/A	wdth=100.0, wght=200.0
Light	wdth=100.0, wght=300.0	wdth=100.0, wght=300.0
Regular	wdth=100.0, wght=400.0	wdth=100.0, wght=400.0
Medium	wdth=100.0, wght=500.0	wdth=100.0, wght=500.0
SemiBold	N/A	wdth=100.0, wght=600.0
Bold	wdth=100.0, wght=700.0	wdth=100.0, wght=700.0
ExtraBold	wdth=100.0, wght=800.0	wdth=100.0, wght=800.0

[code: bad-fvar-instances]

[djrrb]

This is related to #93. It is nice for the variable font instances to match the static fonts, including the Condensed family, so my preference is to leave the instances as they are.

It looks like Google Fonts expects ExtraLight and SemiBold styles, which were not in the original offering of this family, and don’t seem necessary since we made the Light and Bold weights lighter already.

So I say we continue with the weights that we have, but if ExtraLight and SemiBold weights were requested, I don’t have a major objection to adding these at wght=200 and wght=600 (wght=615 internally).

[m4rc1e]

It looks like Google Fonts expects ExtraLight and SemiBold styles, which were not in the original offering of this family, and don’t seem necessary since we made the Light and Bold weights lighter already.

We'd like the ExtraLight and SemiBold please. Our API needs to have weights for every multiple of 100.

Everything else, SGTM.

[djrrb]

Sure! Just letting @lyubomir-popov know I will be adding these two weights unless instructed otherwise.

[lyubomir-popov]

@djrrb what about the italic? It doesn't have 100 iirc

[m4rc1e]

We'd also want the same for the Italic font.

[djrrb]

Both proportional Upright and Italic fonts have a weight range of 100–800, so we can can accommodate an ExtraLight Italic there no problem.

The Mono Upright has a weight range of 100–700, while the Mono Italic has weight range of 400–700. So this will have an ExtraLight but no ExtraLight Italic.

[lyubomir-popov]

ah ok, sorry for the confusion

[djrrb]

ExtraLight and SemiBold added in 0f018d1c0f44c2813e67c4abcccd1ccd159cf437.

This issue still appears as a fail, but now only reports the additional Condensed instances. I am re-adding wontfix tag.

🔥 FAIL
fvar instances are incorrect:
    Delete additional instances

Name	current	expected
Condensed Regular	wdth=75.0, wght=400.0	N/A
Condensed Medium	wdth=75.0, wght=500.0	N/A
Condensed Bold	wdth=75.0, wght=700.0	N/A
Condensed Thin	wdth=75.0, wght=100.0	N/A
Condensed Light	wdth=75.0, wght=300.0	N/A
Condensed ExtraLight	wdth=75.0, wght=200.0	N/A
Condensed SemiBold	wdth=75.0, wght=600.0	N/A
Condensed ExtraBold	wdth=75.0, wght=800.0	N/A
Thin	wdth=100.0, wght=100.0	wdth=100.0, wght=100.0
ExtraLight	wdth=100.0, wght=200.0	wdth=100.0, wght=200.0
Light	wdth=100.0, wght=300.0	wdth=100.0, wght=300.0
Regular	wdth=100.0, wght=400.0	wdth=100.0, wght=400.0
Medium	wdth=100.0, wght=500.0	wdth=100.0, wght=500.0
SemiBold	wdth=100.0, wght=600.0	wdth=100.0, wght=600.0
Bold	wdth=100.0, wght=700.0	wdth=100.0, wght=700.0
ExtraBold	wdth=100.0, wght=800.0	wdth=100.0, wght=800.0

[code: bad-fvar-instances]