canonical / action-build

A Github action for building Snapcraft projects
MIT License
42 stars 22 forks source link

Please create a new release for compatibility with the latest runner images #62

Closed lengau closed 1 year ago

lengau commented 1 year ago

It looks like these images swapped out the docker-moby client and server for docker (20.04, 22.04), and it's causing runs to break when setting up LXD networking (example).

It appears that exec.exec isn't obeying the ignoreReturnCode option, so instead of returning a nonzero value it's throwing an exception.

59 should fix this, so theoretically the action just needs a new release.

lengau commented 1 year ago

Running from master appears to work: https://github.com/canonical/charmcraft/actions/runs/5966477404/job/16186184530?pr=1240

sergiusens commented 1 year ago

Released https://github.com/snapcore/action-build/releases/tag/v1.1.3

max-sixty commented 1 year ago

Hi there — the v1 tag be updated to this? IIUC that's the GHA convention, so it'll flow through to those on @v1

sergiusens commented 1 year ago

@max-sixty it has now, please reopen if not working

max-sixty commented 1 year ago

Thank you!