make server cert path return None if tls disabled

canonical / alertmanager-k8s-operator

This charmed operator automates operation procedures of Alertmanager, the alerting component of Prometheus and Loki, among others.

https://charmhub.io/alertmanager-k8s

Apache License 2.0

4 stars 16 forks source link

make server cert path return None if tls disabled #249

Closed PietroPasotti closed 1 month ago

PietroPasotti commented 2 months ago

title says it all

charm tracing expects Optional[str], where None means: there's no TLS, and str means: here's your cert. Alertmanager is returning str even though the file doesn't exist, which makes charm-tracing log exceptions on every hook.

PietroPasotti commented 1 month ago

obsoleted by #251