canonical / anbox-cloud.io

Anbox cloud demo site
https://anbox-cloud.io/
GNU General Public License v3.0
24 stars 31 forks source link

Add license information in docs footer #335

Closed keirthana closed 5 months ago

keirthana commented 5 months ago

Done

Added Creative Commons license information to docs footer.

QA

Issue / Card

Fixes #

Screenshots

[if relevant, include a screenshot]

webteam-app commented 5 months ago

Demo

Jenkins

demos.haus

keirthana commented 5 months ago

@lorumic I hope I have done this right. I tried based on what was existing in the footer.

lorumic commented 5 months ago

@lorumic I hope I have done this right. I tried based on what was existing in the footer.

@keirthana You can see it in action by scrolling to the bottom of the demo page here. So, you can use this to first check yourself whether this is the visual output that you had in mind.

keirthana commented 5 months ago

@lorumic I hope I have done this right. I tried based on what was existing in the footer.

@keirthana You can see it in action by scrolling to the bottom of the demo page here. So, you can use this to first check yourself whether this is the visual output that you had in mind.

Thank you very much. I thought there was a demo but I tried immediately after raising the PR and the demo server didn't load properly. But now it works.

lorumic commented 5 months ago

Thank you very much. I thought there was a demo but I tried immediately after raising the PR and the demo server didn't load properly. But now it works.

Yes, it takes some time before you can see it because it needs to build. Did you check the visual output now? Does this look like what you had in mind?

image

If yes, I think we can proceed and merge.

keirthana commented 5 months ago

Thank you very much. I thought there was a demo but I tried immediately after raising the PR and the demo server didn't load properly. But now it works.

Yes, it takes some time before you can see it because it needs to build. Did you check the visual output now? Does this look like what you had in mind?

image

If yes, I think we can proceed and merge.

Yes this looks good. We can merge once the PR is approved.