canonical / anbox-cloud.io

Anbox cloud demo site
https://anbox-cloud.io/
GNU General Public License v3.0
24 stars 31 forks source link

[WD-12159] chore: Updated yarn.lock dependencies #344

Closed Kxiru closed 4 months ago

Kxiru commented 4 months ago

Done

QA

Issue / Card

Fixes out of date dependencies

Screenshots

N/A

webteam-app commented 4 months ago

Demo

Jenkins

demos.haus

Kxiru commented 4 months ago

The demo build is failing because it can't find esbuild. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?

Hey David, How do you know that esbuild cannot be found? When I read the error logs, it implies it cannot find build-css and build-js. Is there another place that I should be looking?

edlerd commented 4 months ago

The demo build is failing because it can't find esbuild. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?

Hey David, How do you know that esbuild cannot be found? When I read the error logs, it implies it cannot find build-css and build-js. Is there another place that I should be looking?

From the jenkins log:

#26 0.520 Error: Cannot find module 'esbuild'
#26 0.520 Require stack:
#26 0.520 - /srv/build.js
#26 0.520     at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
#26 0.520     at Module._load (node:internal/modules/cjs/loader:986:27)
#26 0.520     at Module.require (node:internal/modules/cjs/loader:1233:19)
#26 0.520     at require (node:internal/modules/helpers:179:18)
#26 0.520     at Object.<anonymous> (/srv/build.js:1:15)
#26 0.520     at Module._compile (node:internal/modules/cjs/loader:1358:14)
#26 0.520     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
#26 0.520     at Module.load (node:internal/modules/cjs/loader:1208:32)
#26 0.520     at Module._load (node:internal/modules/cjs/loader:1024:12)
#26 0.520     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12) {
#26 0.520   code: 'MODULE_NOT_FOUND',
#26 0.520   requireStack: [ '/srv/build.js' ]
#26 0.520 }
Kxiru commented 4 months ago

@edlerd , After testing, I have realised that tests fail in demo/jenkins because the build scripts rely on all of the dependencies that you have asked me to move to DevDependencies (I ran them one by one to double check). That being said, all of the version have been updated.