search

canonical / argo-operators

Argo Operators
Apache License 2.0
1 stars 10 forks source link

Update `argo-controller` manifests #166

Closed misohu closed 5 months ago

misohu commented 5 months ago

Context

Each charm has a set of manifest files that have to be upgraded to their target version. The process of upgrading manifest files usually means going to the component’s upstream repository, comparing the charm’s manifest against the one in the repository and adding the missing bits in the charm’s manifest.

What needs to get done

https://docs.google.com/document/d/1a4obWw98U_Ndx-ZKRoojLf4Cym8tFb_2S7dq5dtRQqs/edit?pli=1#heading=h.jt5e3qx0jypg

Definition of Done

  1. Manifests are updated
  2. Upstream image is used
syncronize-issues-to-jira[bot] commented 5 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5668.

This message was autogenerated

orfeas-k commented 5 months ago

While working in KFP, there were some changes in argo-related manifests, which we do not include in KFP. When updating argo, we should make sure that updates here are in terms with changes in KFP. Pasting here the changes for reference:

Diff * Adding CRD workfloweventbindings.argoproj.io * Change in CRD workflows.argoproj.io * Changes in CRD workflowtaskresults.argoproj.io * Change in argo-cluster-role ```diff > - workflowartifactgctasks ``` * Change in workflow-controller-configmap ```diff < containerRuntimeExecutor: emissary ``` * Removal of workflow-controller-metrics `Service` * Bump of argo images ```diff < - gcr.io/ml-pipeline/argoexec:v3.3.10-license-compliance --- > - gcr.io/ml-pipeline/argoexec:v3.4.16-license-compliance < image: gcr.io/ml-pipeline/workflow-controller:v3.3.10-license-compliance --- > image: gcr.io/ml-pipeline/workflow-controller:v3.4.16-license-compliance ```
DnPlas commented 5 months ago

Thanks @orfeas-k for the context!