canonical / argo-workflows-rocks

ROCKs for Argo Workflows

Apache License 2.0

0 stars 1 forks source link

Kf 2270 feat argoexec ROCK update per best practices #8

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

Description

Details are in https://github.com/canonical/argo-workflows-rocks/issues/9

Argo Exec ROCK is part of ROCK creation epic. Initial ROCK was created during the workshop. This update introduces unit and integration tests and changes to rockcraft.yaml based on best practices specified in Kuebflow team spec.

Summary of changes:

Updated rockcraft to be up to spec with best practices.

Testing

Manual testing of ROCK was done as per best practices spec.

i-chvets commented 1 year ago

Thanks @i-chvets, the rock looks good, just a comment on the tox.ini and test file as we are moving towards improving the way we build and test rocks.

The tox.ini file in this PR will most likely change, and it's completely up to you, but I would split this PR moving thetests/ and tox.ini changes to another PR and just leaving the rock update.

Done. Will create another PR with tox.ini and test when this one is merged.