search

canonical / base-mlflow

MlFlow image built on top of Ubuntu 22.04
0 stars 1 forks source link

Fix rock for MLflow 1.25 #16

Closed misohu closed 3 months ago

misohu commented 3 months ago

Closes: https://github.com/canonical/base-mlflow/issues/15

We are moving to use rock only instead of the Docker image. I have set the secrets to point to correct docker user.

Note: I am installing MLFLow in Rock directly rather then installing it from requirements as that was the way we used in the Dockerfile.

This rock has been also tested from my personal dockerhub account directly in mlflow operator in this PR (so we know its working).

kimwnasptd commented 3 months ago

Could we also update the README.md of this repo since we are bumping the version?

misohu commented 3 months ago

Hey @orfeas-k we need the mlflow.yaml for artifactory metadata which was used in dockerfile ... I am keeping it there until we decide what to do with the dockerfile.

kimwnasptd commented 3 months ago

Do we still need the Dockerfile now that we converted to rockcraft.yaml file?

misohu commented 3 months ago

Hey @kimwnasptd @orfeas-k, I have removed the Docker image dependancies ... because of that I could move the mlflow to requirements. I have pinned requirements and added update-requirements tox. Now I am testing the image in the charm here https://github.com/canonical/mlflow-operator/actions/runs/10301193187/job/28512189629