search

canonical / bluez.dart

Mozilla Public License 2.0
52 stars 20 forks source link

Add BlueZGattCharacteristic.mtu #93

Closed rohitsangwan01 closed 8 months ago

rohitsangwan01 commented 10 months ago

https://github.com/bluez/bluez/blob/master/doc/org.bluez.GattCharacteristic.rst#uint16-mtu-read-only

github-actions[bot] commented 10 months ago
Hey! rohitsangwan01 has not signed the Canonical CLA which is required to get this contribution merged on this project. Please head over to https://ubuntu.com/legal/contributors to read more about it.
rohitsangwan01 commented 10 months ago

@robert-ancell just signed CLA

rohitsangwan01 commented 10 months ago

Could you please add this to the 'gatt characteristic' test in tests/bluez_test.dart? You will just need to add the MTU property to the test object check it can be read back.

@robert-ancell Done, hope that's the only thing required for test

robert-ancell commented 10 months ago

Just needs the analyze issue and the test failure in the ci. The test could also be merged into the existing test that reads at the properties - no need for a specialist MTU test.

rohitsangwan01 commented 9 months ago

@robert-ancell any update on this pr, by when this will be merged ?

robert-ancell commented 9 months ago

Hi, I've been away but back now. Change looks good, just fix the analyze/test issues and it's ready to land.

rohitsangwan01 commented 9 months ago

@robert-ancell tried fixing the analyzer/test issue, and also signed the CLA