search

canonical / bootstack-actions

Actions for unifying lint, unit and functional tests, and charm and snap releases
0 stars 8 forks source link

Make `commands` a required input and remove its default value #14

Closed agileshaw closed 1 year ago

agileshaw commented 1 year ago

Since different charms/snaps have different ways of calling functional tests with commands, after discussion, we decided to make commands a required input field and define its values in charm/snap's templates. This change should not break any existing CI since we are already passing commands values in templates.

mkalcok commented 1 year ago

Will this change require additional changes in every repository that uses this action?

rgildein commented 1 year ago

Will this change require additional changes in every repository that uses this action?

It should not, because in bootstack templates we were using the default value. It just did not make sense to have default value in both places.

agileshaw commented 1 year ago

@mkalcok Like @rgildein mentioned, this should not have anything breaking effect on current CI configurations. I updated the PR description to include this information.

agileshaw commented 1 year ago

@rgildein @esunar Updated the test. Could you please review the PR again?

BTW, something really weird is happening. I didn't dismiss review, nor removed requests for bootstack-reviewers.

rgildein commented 1 year ago

BTW, something really weird is happening. I didn't dismiss review, nor removed requests for bootstack-reviewers.

I think it because two reviewers give you review? Not sure