canonical / bundle-kubeflow

Charmed Kubeflow
Apache License 2.0
103 stars 50 forks source link

Deploy to AKS and EKS actions always receive the default arguments for bundle versions #1069

Open mvlassis opened 2 weeks ago

mvlassis commented 2 weeks ago

Bug Description

The actions "Deploy to AKS" and "Deploy to EKS" do not process the input of the value "bundle_version" properly. This is because the INPUT_BUNDLE_VERSION environment variable is always empty (seen here). The value is not correctly propagated from the inputs of the workflow to the inputs of the preprocess-input job.

To Reproduce

Run the "Deploy to AKS" action on the main branch with a non-default input for the bundle version like 1.8. Inspect the result of the action and you will se that the tests run for 1.8, 1.9, and latest.

Environment

.

Relevant Log Output

Run python scripts/gh-actions/parse_versions.py
  python scripts/gh-actions/parse_versions.py
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.12.5/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.5/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.5/x64/lib
bundle_versions=["1.8", "1.9", "latest"]

Additional Context

An easy fix is to run add the value of ${{ github.event.inputs.bundle_version }} in this line, so the script is called with this one argument, which can then be passed to the function inside the Python file.

syncronize-issues-to-jira[bot] commented 2 weeks ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6266.

This message was autogenerated