search

canonical / canonical-indico-customization-files

This repository holds the Indico customization files used for the Canonical event management system deployment
Apache License 2.0
2 stars 5 forks source link

Use a different label for accepted registrations for internal events #15

Closed kewisch closed 1 year ago

kewisch commented 1 year ago

EA Team would like to change the label for completed registrations. Since the HTML template is very general-purpose and I don't want to copy/paste the whole thing, I'm going with a more simple javascript hack that changes the labels accordingly.

petesfrench commented 1 year ago

LGTM, but can this not be accomplished by extending the template and just updating the bits you need?

kewisch commented 1 year ago

Using the template means I need to copy all of https://github.com/indico/indico/blob/dcc336fac1fc98941eb168f15fa8a57f4223c105/indico/modules/events/registration/templates/display/registration_summary.html#L13 into the customization files to change the text. This is more susceptible to issues when upgrading.

petesfrench commented 1 year ago

You're right, much better this way