search

canonical / canonical-indico-customization-files

This repository holds the Indico customization files used for the Canonical event management system deployment
Apache License 2.0
2 stars 5 forks source link

Make top bar button white for accessibility reasons #21

Closed petesfrench closed 8 months ago

petesfrench commented 10 months ago

Design team 'Public'/'Private' button in the top bar be white to match the rest of the other buttons for accessibility reasons. https://warthogs.atlassian.net/browse/WD-5291

petesfrench commented 10 months ago

@carkod Could you look at this one also please?

carkod commented 10 months ago

@carkod Could you look at this one also please?

How do I QA this?

petesfrench commented 10 months ago

Hey @kewisch, could you take a look at this please?

kewisch commented 10 months ago
image

Is this the intended look? I just tested this in the style editor, so maybe something is wrong. Do you have more background why a white button will increase accessibility? Is this about contrast ratio?

Design may have a better expert opinion, but I do prefer the additional color the orange button brings in. Note also that some event themes overwrite the button color on event pages, e.g. the 'Canonical' theme makes it aubergine.

petesfrench commented 10 months ago

@kewisch I wasn't aware there were differences across different themes. I would image this would also be in-accessible. I would suggest we keep the navigation in the default colours in this case. But I will bring this up with design first and see if they are willing to compromise.

petesfrench commented 8 months ago

Closing as this work is no longer needed.