Closed d0ugal closed 4 years ago
The codeTheme does exist but there seems to being some issues with updating themes automatically. Could you switch to another theme and back to the Canonical dark theme and see if that refreshes the styles. Another option to test this is to copy these settings as a custom theme and see it work. If you still see the issue please reopen and comment.
Changing themes works very reliably for me with every theme. The only difference is that Canonical Dark does not highlight the code. If I edit the theme and change it to "github"
or "monokai"
then it also works fine. If I use "github-dark"
on another theme it then also drops the colours.
FWIW, I tested it with a very simple message in a chat with myself.
```python
print(1)
print("two")
```
I am also using the MM snap if that makes a difference.
Oh I see what you mean the syntax highlighting is missing. Strange, the classes are there.
@d0ugal PR ready if you wanted to review ^
Looks good to me, thanks!
Hey @anthonydillon, we're still seeing the issue and @hatched has found something.
I dug a bit deeper. It looks like the culprit is the monokai
theme not having the appropriate classes (or maybe isn't being applied at all). Maybe we can change that to something else? Does this need to be installed separately?
It was fixed in the latest released version: https://github.com/canonical-web-and-design/canonical-mattermost-themes/releases/tag/v1.0.2
Here is the ticket to release it: https://portal.admin.canonical.com/C126959/
It was fixed in the latest released version: https://github.com/canonical-web-and-design/canonical-mattermost-themes/releases/tag/v1.0.2
Here is the ticket to release it: https://portal.admin.canonical.com/C126959/
Just confirming that I pasted the contents of the canonical dark theme in my MM client (MacOS) custom theme textbox and it fixed the syntax highlighting issue.
Although, I checked with the mobile client (iPhone) and the syntax highlighting isn't working.
We are unfortunately blocked waiting for this change to be rolled out.
This has now been released. Please change your theme to the light one and then back to the dark one to get the latest changes.
For some reason the Canonical Dark theme doesn't colour code. The Canonical Light and all other themes do.
"codeTheme": "github-dark"
Maybe this should be "monokai" or another name? I guess github-dark doesn't exist?