Closed nathanclairmonte closed 6 months ago
Demo starting at https://canonical-com-1188.demos.haus
Attention: Patch coverage is 93.84615%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 71.45%. Comparing base (
b62710c
) to head (5824420
). Report is 38 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
webapp/application.py | 85.18% | 4 Missing :warning: |
webapp/google_calendar.py | 91.66% | 2 Missing :warning: |
tests/test_application.py | 97.87% | 1 Missing :warning: |
tests/test_google_calendar.py | 96.87% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just a note that we usually follow on Sites, would be nice not to have all those commits that are not useful like "Fix lint", "Cleanup print statements", they don't provide any value to the Git history. But I can see the PR is becoming too large to pick out those commits, just so you know in the future, you could do a git commit --amend
to put it in the previous commit. Thanks
@carkod Thank you for the info and suggestions! I wasn't aware of this git command, will utilise it in future.
I've also addressed the import organization in google_calendar.py
and the commented-out line in _withdrawal_notification-email.html
.
Thanks again 🙏
Done
delete_event_from_interview_calendar()
function which as you might guess deletes an interview from the interview calendar (the interview calendar is the shared calendar on which all interviews are scheduled)sendUpdates="all"
to the delete request itself. This ensures a notification is sent to all attendees of the meeting telling them that it was canceled. The old parameter for this wassendNotifications
(a boolean), but that has since been deprecated./templates/application/withdrawal.html
template (which is displayed once the candidate withdrawal is confirmed) to display the emails that would have been sent to the interviewers if not in debug mode.application_withdrawal()
(line 465 in/webapp/application.py
) function is called.scheduled
(the other options for this status arecomplete
andawaiting_feedback
, both of which indicate that the interview has already happened and thus does not need to be deleted).awaiting_feedback
so that we can alert those interviewers that a scorecard submission is no longer necessary. These interview events are not deleted however, as they will have already passed.QA
Prep
SERVICE_ACCOUNT_EMAIL
andSERVICE_ACCOUNT_PRIVATE_KEY
to.env.local
(for Google Calendar API)Testing the auto-deletion flow
dotrun
https://harvest.greenhouse.io/v1/applications/{{application_id}}
endpoint on the Harvest API)/templates/application/withdrawal.html
template, which should have the email(s) that would've been sent to the interviewer(s).(btw, let me know if this is too long! I tried to be as like thorough as possible with the QA steps)
Issue / Card
WD-7721
Screenshots
[if relevant, include a screenshot]