canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

auto delete interviews on withdrawal (WD-7721) #1188

Closed nathanclairmonte closed 6 months ago

nathanclairmonte commented 7 months ago

Done

QA

Prep

Testing the auto-deletion flow

(btw, let me know if this is too long! I tried to be as like thorough as possible with the QA steps)

Issue / Card

WD-7721

Screenshots

[if relevant, include a screenshot]

webteam-app commented 7 months ago

Demo starting at https://canonical-com-1188.demos.haus

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 93.84615% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.45%. Comparing base (b62710c) to head (5824420). Report is 38 commits behind head on main.

Files Patch % Lines
webapp/application.py 85.18% 4 Missing :warning:
webapp/google_calendar.py 91.66% 2 Missing :warning:
tests/test_application.py 97.87% 1 Missing :warning:
tests/test_google_calendar.py 96.87% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1188 +/- ## ========================================== + Coverage 66.55% 71.45% +4.90% ========================================== Files 10 12 +2 Lines 891 1023 +132 ========================================== + Hits 593 731 +138 + Misses 298 292 -6 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1188/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.45% <93.84%> (+4.90%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carkod commented 6 months ago

Just a note that we usually follow on Sites, would be nice not to have all those commits that are not useful like "Fix lint", "Cleanup print statements", they don't provide any value to the Git history. But I can see the PR is becoming too large to pick out those commits, just so you know in the future, you could do a git commit --amend to put it in the previous commit. Thanks

nathanclairmonte commented 6 months ago

@carkod Thank you for the info and suggestions! I wasn't aware of this git command, will utilise it in future.

I've also addressed the import organization in google_calendar.py and the commented-out line in _withdrawal_notification-email.html.

Thanks again 🙏