canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

Add the Enterprise Sales Representative video to the candidate page #1189

Closed anthonydillon closed 8 months ago

anthonydillon commented 8 months ago

Done

Add the Enterprise Sales Representative video to the candidate page Could not use the hiring JSON as this is on the hiring lead level not the individual role Updated the title text

QA

webteam-app commented 8 months ago

Demo starting at https://canonical-com-1189.demos.haus

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.40%. Comparing base (9f0f213) to head (dbba524). Report is 4 commits behind head on main.

Files Patch % Lines
webapp/application.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1189 +/- ## ========================================== - Coverage 66.55% 66.40% -0.15% ========================================== Files 10 10 Lines 891 893 +2 ========================================== Hits 593 593 - Misses 298 300 +2 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1189/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `66.40% <0.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akbarkz commented 8 months ago

@anthonydillon Is there an open position currently that we could use to test this change? I couldn't find one.

anthonydillon commented 8 months ago

Nope, as mentioned in the QA steps this position is not open yet. I'll try and assign a test candidate to the position but not sure I can if it's not open

carkod commented 8 months ago

@anthonydillon can you squash/rebase your "Fix lint" commits? They are not very useful in Git history.