search

canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

Build /solutions/telco #1193

Closed mtruj013 closed 8 months ago

mtruj013 commented 8 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-8463

webteam-app commented 8 months ago

Demo starting at https://canonical-com-1193.demos.haus

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.40%. Comparing base (9f0f213) to head (484f87a). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1193 +/- ## ========================================== - Coverage 66.55% 66.40% -0.15% ========================================== Files 10 10 Lines 891 893 +2 ========================================== Hits 593 593 - Misses 298 300 +2 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1193/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1193/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `66.40% <ø> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sophie-32 commented 8 months ago

Put a note in Figma for @lyubomir-popov cc'ing @mtruj013 about some missing logos

lyubomir-popov commented 8 months ago

@mtruj013 these two carousels are paginating in sync image

mtruj013 commented 8 months ago

@lyubomir-popov should be fixed now, might need to refresh the demo

lyubomir-popov commented 8 months ago

@mtruj013 nice work, I pushed a few small fixes - mostly around blurry images. QA done from my side. +1