canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

Add logic for loading-spinner on forms #1207

Closed petesfrench closed 6 months ago

petesfrench commented 6 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-8603

webteam-app commented 6 months ago

Demo starting at https://canonical-com-1207.demos.haus

lizzochek commented 6 months ago

Except the comment from Carlos looks good to me

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.45%. Comparing base (472e0e8) to head (4a76f4c). Report is 102 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1207 +/- ## ========================================== + Coverage 66.36% 71.45% +5.09% ========================================== Files 10 12 +2 Lines 886 1023 +137 ========================================== + Hits 588 731 +143 + Misses 298 292 -6 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.45% <ø> (+5.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.