canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

Fix inverted link color #1214

Closed mtruj013 closed 7 months ago

mtruj013 commented 8 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-9655

Screenshots

image

webteam-app commented 8 months ago

Demo starting at https://canonical-com-1214.demos.haus

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.45%. Comparing base (49c790a) to head (0d86269). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1214 +/- ## ======================================= Coverage 71.45% 71.45% ======================================= Files 12 12 Lines 1023 1023 ======================================= Hits 731 731 Misses 292 292 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1214/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1214/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.45% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bartaz commented 8 months ago

Should be fixed in global nav by properly triggering dark theme on dropdown: https://github.com/canonical/global-nav/pull/282

mtruj013 commented 7 months ago

Fixes applied in https://github.com/canonical/global-nav/pull/282, https://github.com/canonical/canonical.com/pull/1217/