Reimplement Delete Interview On Withdrawal, With New Deletion Logic

nathanclairmonte commented 6 months ago

add new interview deletion logic

Done
Added a new function is_in_interview_calendar() to the google calendar API class which takes a calendar event ID and checks if this event exists on the Interview Calendar or not.
Updated previous deletion logic to only attempt deletion if the interview event is on the Interview Calendar. If it isn't we still run through the withdrawal process, we just don't attempt deletion.
Updated the interview canceled email template to indicate whether the interview was deleted or not.
Added tests for the deletion process as well as google calendar API class.

QA

Prep

Add SERVICE_ACCOUNT_EMAIL and SERVICE_ACCOUNT_PRIVATE_KEY to .env.local (for Google Calendar API)
Create a test candidate on GH for the "Dev - test 1" job. Make sure to input your email address (or one you have access to) since it will be needed to set the candidate's availabilities
Move the test candidate to the "Early Stage Interviews" stage.
Add yourself as a default interviewer for this candidate.
Input candidate availabilities via email specifically. I.e. click "Request Availability", send the email, fill out the form received in email.
Schedule interviews:
- For auto-scheduled interviews: Wait for main interview-scheduler cronjob to run (it runs every 4 hours) or run the test-scheduler cronjob, then an interview should be scheduled.
- NB: I also have a local script that can schedule these interviews the same way the interview-scheduler does, so if you aren't getting one scheduled when it runs (this can happen sometimes if it just doesn't find one to schedule) or if it's just taking too long, let me know and I can manually schedule a test interview for you.
- For manually scheduled interviews: Go to Greenhouse and click "Schedule Interview" for your test candidate. On the next screen, ensure that the Interview Calendar is selected and hit continue. On the final screen, make sure to add a video link, then click "Send Invites" (NOT "Open in Google", as this causes a glitch and the interview ends up not on the Interview Calendar).
Make sure the interview actually shows up in GH, otherwise it won't show up in the scheduled interviews returned from the Harvest API.
Once there is a scheduled interview in GH, you can move on to the steps below to run the site and test the deletion process.

Testing the auto-deletion flow

Check out this feature branch
Run the site with dotrun
View the site locally in your web browser at: http://localhost:8002/
Navigate to the test candidate's candidate page (you can get the candidate page URL from the https://harvest.greenhouse.io/v1/applications/{{application_id}} endpoint on the Harvest API)
Click the withdraw button, enter the email you put as the candidate's email, select any reason and click submit
On the subsequent page, you should see a debug message along with the withdrawal confirmation email that would have been sent to the candidate. Click that link to confirm the withdrawal.
This should reject the candidate on GH, delete any upcoming interviews, and then render the /templates/application/withdrawal.html template, which should have the email(s) that would've been sent to the interviewer(s).

Issue / Card

Fixes #

Screenshots

[if relevant, include a screenshot]

webteam-app commented 6 months ago

Files	Patch %	Lines
webapp/application.py	85.18%	4 Missing :warning:
webapp/google_calendar.py	50.00%	4 Missing :warning:
tests/test_google_calendar.py	97.22%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## main #1228 +/- ## ========================================== + Coverage 66.14% 71.51% +5.36% ========================================== Files 10 12 +2 Lines 898 1039 +141 ========================================== + Hits 594 743 +149 + Misses 304 296 -8 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.51% <92.30%> (+5.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

canonical / canonical.com