candidate page notification about received written interview

mariuskava commented 5 months ago

Done

https://github.com/canonical/canonical.com/pull/1245/commits/b495016b51a756083101ecd57748d602eaea03ee Candidate page shows notification about received written interview (main requirement)

https://github.com/canonical/canonical.com/pull/1245/commits/c6c24299b50234c5aaeef13f98cc5d27b49dc5a6 Fixed djlint errors. Before there was a div opened inside if block and closed outside of it. djlint didn't like that.

https://github.com/canonical/canonical.com/pull/1245/commits/fef0c3af57bcd2f54abae694723c4d28a622c641 djlint --reformat

https://github.com/canonical/canonical.com/pull/1245/commits/6db00c00a55e8fd6eaa1a08659210b238e575980 keep css class names inplace

QA

Check out this feature branch
Run the site using the command dotrun
View the site locally in your web browser at: http://0.0.0.0:8002/
Run through the following QA steps
Check fake candidate page with written interview submitted
Check fake candidate page without written interview submitted

Screenshots

Screenshot from 2024-04-25 14-48-44

Screenshot from 2024-04-25 14-49-39

webteam-app commented 5 months ago

I have doubts about declared jinja variables. IMHO html looks nicer without "ifs" and one does not need to repeat the same condition several times. However, I would prefer to minimize flow control inside jinja temaplate and have those "view toggles" in the python code and pass them via flask.render_template.

Let me know what you think @andesol @nathanclairmonte @minkyngkm

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.51%. Comparing base (376c630) to head (6db00c0). Report is 27 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1245 +/- ## ========================================== + Coverage 66.14% 71.51% +5.36% ========================================== Files 10 12 +2 Lines 898 1039 +141 ========================================== + Hits 594 743 +149 + Misses 304 296 -8 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1245/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.51% <ø> (+5.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

canonical / canonical.com