canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

Inherit dark colours on homepage #1258

Closed britneywwc closed 5 months ago

britneywwc commented 5 months ago

Done

QA

Issue / Card

Fixes WD-11489

Screenshots

[if relevant, include a screenshot]

webteam-app commented 5 months ago

Demo

Jenkins

demos.haus

jmuzina commented 5 months ago

I think I'm seeing slight visual differences in the color of the rules and links here:

Demo:

Screenshot 2024-05-23 at 11 10 21 AM

Production:

Screenshot 2024-05-23 at 11 10 25 AM
petesfrench commented 5 months ago

@jmuzina I believe the 'demo' version is what it is supposed to look like. Although I might be wrong, @lyubomir-popov?

britneywwc commented 5 months ago

Hey @jmuzina, the demo version is using the updated link colours from Vanilla. Might be worth getting a visual review for this, thanks!

jmuzina commented 5 months ago

Hey @jmuzina, the demo version is using the updated link colours from Vanilla. Might be worth getting a visual review for this, thanks!

Yes it looks like current production is mistakenly using some light theme colors and this PR is fixing that. I'll let @lyubomir-popov confirm :)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.51%. Comparing base (376c630) to head (6ded9fc). Report is 43 commits behind head on main.

:exclamation: Current head 6ded9fc differs from pull request most recent head 077c586

Please upload reports for the commit 077c586 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1258 +/- ## ========================================== + Coverage 66.14% 71.51% +5.36% ========================================== Files 10 12 +2 Lines 898 1039 +141 ========================================== + Hits 594 743 +149 + Misses 304 296 -8 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.51% <ø> (+5.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carkod commented 5 months ago

Can you rebase? I've fixed the dotrun action

lyubomir-popov commented 5 months ago

Can we also please add is-muted to all hrs that are inside top level sections (only the <hr> right above h2 headings, spanning the full fixed width, should not be muted). Like these for example: image

lyubomir-popov commented 5 months ago

@jmuzina I believe the 'demo' version is what it is supposed to look like. Although I might be wrong, @lyubomir-popov?

correct