Closed britneywwc closed 5 months ago
I think I'm seeing slight visual differences in the color of the rules and links here:
Demo:
Production:
@jmuzina I believe the 'demo' version is what it is supposed to look like. Although I might be wrong, @lyubomir-popov?
Hey @jmuzina, the demo version is using the updated link colours from Vanilla. Might be worth getting a visual review for this, thanks!
Hey @jmuzina, the demo version is using the updated link colours from Vanilla. Might be worth getting a visual review for this, thanks!
Yes it looks like current production is mistakenly using some light theme colors and this PR is fixing that. I'll let @lyubomir-popov confirm :)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.51%. Comparing base (
376c630
) to head (6ded9fc
). Report is 43 commits behind head on main.:exclamation: Current head 6ded9fc differs from pull request most recent head 077c586
Please upload reports for the commit 077c586 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you rebase? I've fixed the dotrun action
Can we also please add is-muted
to all hr
s that are inside top level sections (only the <hr>
right above h2 headings, spanning the full fixed width, should not be muted). Like these for example:
@jmuzina I believe the 'demo' version is what it is supposed to look like. Although I might be wrong, @lyubomir-popov?
correct
Done
is-dark
from hr tagsis-dark
to parent HTMLQA
Issue / Card
Fixes WD-11489
Screenshots
[if relevant, include a screenshot]