canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

WD-11799 - fix homepage modal styling #1265

Closed lizzochek closed 5 months ago

lizzochek commented 5 months ago

Done

Fix homepage modal styling

QA

Issue / Card

WD-11799

webteam-app commented 5 months ago

Demo

Jenkins

demos.haus

juanruitina commented 5 months ago

This is no longer broken. I defer to @lyubomir-popov on whether the form should be dark theme or not.

lizzochek commented 5 months ago

@juanruitina agreed with Lyubo that it should be dark

lyubomir-popov commented 5 months ago

The background page scrolls, instead of the form. @juanruitina shouldn't background content scroll be disdabled?

juanruitina commented 5 months ago

The background page scrolls, instead of the form. @juanruitina shouldn't background content scroll be disdabled?

Yes, I think at least the background scroll should be disabled. @lizzochek can you tweak that?

lizzochek commented 5 months ago

@juanruitina we have the background scroll enabled on other modals too. do we want to remove it from everywhere?

juanruitina commented 5 months ago

@lizzochek Yes, they should behave consistently.

lizzochek commented 5 months ago

@juanruitina @lyubomir-popov /contact-us page also uses this form, but is not in a dark mode, should I leave the form white for now, fix it to be black or what? thanks for your quick responses, we need it done today

juanruitina commented 5 months ago

I'm satisfied as long as the modal is readable in both places (it isn't at the moment).

lyubomir-popov commented 5 months ago

@juanruitina @lyubomir-popov /contact-us page also uses this form, but is not in a dark mode, should I leave the form white for now, fix it to be black or what? thanks for your quick responses, we need it done today

can we have the partial accept a theme parameter? then add is-dark as a class at the top, everything should follow suit.