Closed lizzochek closed 5 months ago
This is no longer broken. I defer to @lyubomir-popov on whether the form should be dark theme or not.
@juanruitina agreed with Lyubo that it should be dark
The background page scrolls, instead of the form. @juanruitina shouldn't background content scroll be disdabled?
The background page scrolls, instead of the form. @juanruitina shouldn't background content scroll be disdabled?
Yes, I think at least the background scroll should be disabled. @lizzochek can you tweak that?
@juanruitina we have the background scroll enabled on other modals too. do we want to remove it from everywhere?
@lizzochek Yes, they should behave consistently.
@juanruitina @lyubomir-popov /contact-us page also uses this form, but is not in a dark mode, should I leave the form white for now, fix it to be black or what? thanks for your quick responses, we need it done today
I'm satisfied as long as the modal is readable in both places (it isn't at the moment).
@juanruitina @lyubomir-popov /contact-us page also uses this form, but is not in a dark mode, should I leave the form white for now, fix it to be black or what? thanks for your quick responses, we need it done today
can we have the partial accept a theme parameter? then add is-dark as a class at the top, everything should follow suit.
Done
Fix homepage modal styling
QA
Issue / Card
WD-11799