Closed petesfrench closed 3 months ago
@Sophie-32 @lyubomir-popov Can you take a look please
Looks good! Couple of nit picks:
Can we please wrap the hero's paragraph in a p-section--shallow, as in this example: https://vanillaframework.io/docs/examples/patterns/hero/hero-rules
Small caps or h2 would work better here IMO - I think the small caps were lost due to missing fonts in figma:
For the quotes, can we test the new HOC/pattern I've been building - @Sophie-32 would that be ok with you? Made a mockup with all responsive version here - https://www.figma.com/design/Hll6ZRvHyTTGBZZSoRd8ei/Higher-order-components-(HOCs)?node-id=1066-9071&t=YGFnP7FRFJ2xBd9K-1
@lyubomir-popov Can you take another look please?
@Sophie-32 Could you take a look at this please
These look blurry, cdn issue again I guess? ![Uploading image.png…]()
Thanks @petesfrench - the only issue I see is blurry logos, could you please double check the cdn versions and why are they blurry. I believe the original assets were exported at 3x the requireed resolution, sao there shouldn't be a problem
@lyubomir-popov I have update to not go through the CDN. It seems we are having some kind of issue either through the python image template or the CDN. I have made an issue to look into this here: https://warthogs.atlassian.net/browse/WD-12738
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-12009