canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

Implement the navigation and reduced navigation #1290

Closed petesfrench closed 2 months ago

petesfrench commented 2 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12668

Screenshots

Regular navigation: image Reduced navigation: image Regular navigation (search open): image Reduced navigation (search open): image

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

akbarkz commented 2 months ago

@petesfrench Two findings with the Search functionality:

  1. The background of the search field is black, while as on ubuntu.com it's white
  2. The focus is not automatically put to the search field when you open it
petesfrench commented 2 months ago

@akbarkz

  1. This is how appears on Vanilla with the is-dark them applied to the page, same as c.com. We should be aligning with Vanilla as much as possible, not u.com.
  2. Fixed.

Can you take another look please?

akbarkz commented 2 months ago

@petesfrench After typing something into the search field and clicking on "X" icon to erase it, it doesn't work.

petesfrench commented 2 months ago

@akbarkz I think that is getting into the search implementation. My thought process behind this is that 'clear search' is something I would implement with the 'search initialization', along with the event listener for the search button, keyboard events, search functionality etc.

petesfrench commented 2 months ago

@akbarkz I think that is getting into the search implementation. My thought process behind this is that 'clear search' is something I would implement with the 'search initialization', along with the event listener for the search button, keyboard events, search functionality etc.