canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

refactor: Updates the reduced nav search to use newest Vanilla pattern #1294

Closed petesfrench closed 2 months ago

petesfrench commented 2 months ago

Don't merge: Until the branch this PR references has been merged

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-13043

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

akbarkz commented 2 months ago

Two finding during QA:

  1. The word "Canonical" is not aligned with the bubble logo below Screenshot 2024-07-09 at 16 32 21

  2. When clicking on "Menu" button on mobile screen, it navigates to /navigation. It wasn't like this before.

petesfrench commented 2 months ago

@akbarkz

  1. I flagged that with Bartek and he informed me that is the expected behaviour, see the conversation
  2. That is the fallback link for when JS fails/doesn't load etc. In this case, as this is the sliding nav, the JS doesn't exist. So this is the expected behavior