canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

Implement search #1296

Closed petesfrench closed 2 months ago

petesfrench commented 2 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12996

Screenshots

image image image

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

petesfrench commented 2 months ago

@lyubomir-popov can you take a look a the search results page, I couldn't find a design for it so just tried to make it align with the rest of the site. https://canonical-com-1296.demos.haus/search?q=pro

lyubomir-popov commented 2 months ago

looks good, a couple of things I noticed:

juanruitina commented 2 months ago

@lyubomir-popov I'm personally OK with keeping the two search fields even if redundant, they're not both visible at the same time without user interaction. Having it in the text body is useful, having it in the navigation is predictable. I see that on apple.com and redhat.com.

If you think it's problematic visually, I see microsoft.com hiding the search button from the navigation when on a search page, I think that's also reasonable. The option I would oppose is hiding the always-visible field below the "Search results for [...]" heading, too much friction.