canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

WD-12223 Refreshed /data/opensearch #1308

Closed immortalcodes closed 2 months ago

immortalcodes commented 2 months ago

Done

Issue / Card

Fixes # WD-12223

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

immortalcodes commented 2 months ago

Thanks @immortalcodes , some comments in the code. I also left some comments on the figma about the muted headings if you could have a look and I believe we're also missing updated assets as the ones in the demo don't match the figma: image vs: Screenshot from 2024-07-22 13-14-40

Thanks @immortalcodes , some comments in the code. I also left some comments on the figma about the muted headings if you could have a look and I believe we're also missing updated assets as the ones in the demo don't match the figma: image vs: Screenshot from 2024-07-22 13-14-40

The assets are the ones that are provided in the copydoc so I followed them, shall I give preference to figma assets? There is comment about same by Sophie as well in the figma.

akbarkz commented 2 months ago

@immortalcodes The alignment of this section on small screen doesn't look right: Screenshot 2024-07-26 at 12 23 54

Also, the font is different in the wireframe

lyubomir-popov commented 2 months ago

pls remove padding on the list items:

image

image

image

image

image

lyubomir-popov commented 2 months ago

last thing - p-section--shallow on these please: image