canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

WD-12230 Created /data/opensearch/what-is-opensearch #1311

Closed immortalcodes closed 3 months ago

immortalcodes commented 3 months ago

Done

QA

Issue / Card

Fixes # WD-12230

webteam-app commented 3 months ago

Demo

Jenkins

demos.haus

immortalcodes commented 3 months ago

This page has no links to it. There is even a link to what is opensearch in the parent page but that links to a blog post. If there are no links, no one is going to discover the page.

There is a link in the homepage to this page by heading Learn more about OpenSearch >. This should work fine?

lyubomir-popov commented 3 months ago

image

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature-opensearch@c80e7f9). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature-opensearch #1311 +/- ## ===================================================== Coverage ? 72.04% ===================================================== Files ? 13 Lines ? 1073 Branches ? 0 ===================================================== Hits ? 773 Misses ? 300 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1311/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `72.04% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

immortalcodes commented 3 months ago
  • muted hrs missing here, remove padding form <li>s image
  • as in the other prs, this needs adjustments tyo layout on medium: image image image image

image

  • pls hide these images on small and medium image
  • this has a lot of space at the bottom - can you please check for discrepancies with the vanilla example image

The code block seems to be same in Vanilla image