canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

[WD-12238] new webpage at /data/opensearch/managed #1317

Closed akbarkz closed 1 month ago

akbarkz commented 2 months ago

Done

Added new webpage according to this copy doc and this design.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12238

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

lyubomir-popov commented 2 months ago

all images are lacking the vanilla highlighted background image

can we do this on medium: image

hide image on medium pls: image

this should look like the HOC screenshotted below: image image

This shouyld be an h2, too long for capitals image

equal heights of the grey boxes here pls image

The rest looks great!

akbarkz commented 2 months ago

@lyubomir-popov I addressed all your remarks, except one that is about having equal height for pricing cards. Could you please help me with that, cause using existing Vanilla utilities does not seem to be able to help.

lyubomir-popov commented 2 months ago

can you restart the demo pls - I get a 404

lyubomir-popov commented 2 months ago

For the equal heights, since we don't have a component for this in vanilla (we only seem to use this on the u.c site - is that correct @Sophie-32 ?) maybe just hardcoded min-heights? This is what I get:

image

for the signpost logo, can we please use this file at 33px height, width set to auto: https://assets.ubuntu.com/v1/ff455ff8-opensearch-logo--signpost.png

akbarkz commented 1 month ago

@lyubomir-popov thanks for the review! I replaced the logo and fixed the layout for it, I noticed it was behaving weirdly for smaller screens. As for cards, I added min-height as you suggested. Overall it looks good now, but on some smaller screen sizes they still differ in height. So please have a look and see if we're fine with that.

lyubomir-popov commented 1 month ago

@akbarkz Just one question, this has a play icon, shouldn't it be clickable? image The rest looks great!

anthonydillon commented 1 month ago

Should there be a link to this new page somewhere?