Implement the Jinja logic for the desktop navigations dropdowns - Githubissues

canonical / canonical.com

Repository for the new version of canonical.com

Other

33 stars 66 forks source link

Implement the Jinja logic for the desktop navigations dropdowns #1322

Closed petesfrench closed 1 month ago

petesfrench commented 1 month ago

Done

Implements the logic for rendering the 3 different dropdown views, see figma
Makes some changes to the navigaiton.yaml to make processing it easier
This led to some refactoring of how the mobile view is rendered
Some refactoring to reuse some templates and move sections into their own templates
move the SCSS into a separate file with separate mixins. This is mostly to make up-streaming it easier

QA

please ignore keyboard navigation, careers roles not appearing and the giant black boxes which will later be images, they are handled in separate tickets

Compare what I have to the figma design
Make sure all the content is there and the links work etc
Check the Jinja logic and Scss makes sense etc, check for repeating code or when things could be made clearer (naming, structure etc)

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12670

Screenshots

View 1:

View 2:

View 3:

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

petesfrench commented 1 month ago

thanks @britneywwc, could you take another look pls