Closed immortalcodes closed 1 month ago
@immortalcodes I added some comments on the figma file
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
feature-mongodb@949256e
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@immortalcodes just 2 very minor things left over! tagged you in the figma
I have left a comment in Jira, as currently this page is floating in space. I've asked the pdm to provide some way to navigate to the page: https://warthogs.atlassian.net/browse/WD-12243?focusedCommentId=553775
We might want to revise the table, as personally, I'm not sure what it represents. Specifically the 'Supported data types' section:
This looks to me like there is an alignment problem. I believe all text should start on the same line, @mattea-turic ?:
We might want to revise the table, as personally, I'm not sure what it represents. Specifically the 'Supported data types' section:
Do you mean a design overhaul? Or just something with widths of the columns
We are going to have to do something about the table on mobile view. You can probably just use the 'p-table--mobile-card' class.
We are going to have to do something about the table on mobile view. You can probably just use the 'p-table--mobile-card' class.
This might not project the intended meaning here, see below:
@juanruitina or @Sophie-32 - for the table here, should we do a horizontal scroll? That would be my preference.
(I'd probably go for that yes, but I see it's been merged already)
Done
Created data/mongodb/what-is-mongodb Assets are still to be updated
QA
./run serve
Issue / Card
Fixes # WD-12243
Screenshots
[if relevant, include a screenshot]