canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

WD-12243 Dev Create data/mongodb/what-is-mongodb #1343

Closed immortalcodes closed 1 month ago

immortalcodes commented 1 month ago

Done

Created data/mongodb/what-is-mongodb Assets are still to be updated

QA

Issue / Card

Fixes # WD-12243

Screenshots

[if relevant, include a screenshot]

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

mattea-turic commented 1 month ago

@immortalcodes I added some comments on the figma file

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature-mongodb@949256e). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature-mongodb #1343 +/- ## ================================================== Coverage ? 72.04% ================================================== Files ? 13 Lines ? 1073 Branches ? 0 ================================================== Hits ? 773 Misses ? 300 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `72.04% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattea-turic commented 1 month ago

@immortalcodes just 2 very minor things left over! tagged you in the figma

petesfrench commented 1 month ago

I have left a comment in Jira, as currently this page is floating in space. I've asked the pdm to provide some way to navigate to the page: https://warthogs.atlassian.net/browse/WD-12243?focusedCommentId=553775

petesfrench commented 1 month ago

We might want to revise the table, as personally, I'm not sure what it represents. Specifically the 'Supported data types' section: image

petesfrench commented 1 month ago

This looks to me like there is an alignment problem. I believe all text should start on the same line, @mattea-turic ?: image

immortalcodes commented 1 month ago

We might want to revise the table, as personally, I'm not sure what it represents. Specifically the 'Supported data types' section: image

Do you mean a design overhaul? Or just something with widths of the columns

petesfrench commented 1 month ago

We are going to have to do something about the table on mobile view. You can probably just use the 'p-table--mobile-card' class. image

immortalcodes commented 1 month ago

We are going to have to do something about the table on mobile view. You can probably just use the 'p-table--mobile-card' class. image

This might not project the intended meaning here, see below: image

lyubomir-popov commented 1 month ago

@juanruitina or @Sophie-32 - for the table here, should we do a horizontal scroll? That would be my preference.

juanruitina commented 1 month ago

(I'd probably go for that yes, but I see it's been merged already)