feat: Only close the navigation when resizing horizontally - Githubissues

canonical / canonical.com

Repository for the new version of canonical.com

Other

34 stars 71 forks source link

feat: Only close the navigation when resizing horizontally #1344

Closed petesfrench closed 3 months ago

petesfrench commented 3 months ago

Done

Adds logic to only close the navigation when resizing horizontally. For context: Vanilla added this the feature to close when resizing as there was still some issue going fluidly from mobile to desktop. This was causing a bug on mobile when you scrolled down and the search hid itself.

QA

Open the demo on a mobile device with chrome
Open then navigation and going to a section which is scroll-able (Products > Private cloud, for ex.)
Start to scroll down to reveal the rest of the navigation and causing the search bar to hide itself.
See that the navigation stays open.
Check that the navigation closes on horizontal resize on desktop.

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-14167

webteam-app commented 3 months ago

Demo

Jenkins

demos.haus