search

canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

feat: /data/mongodb revamp #1348

Closed mtruj013 closed 1 month ago

mtruj013 commented 1 month ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12347

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

mtruj013 commented 1 month ago

Thanks @britneywwc! Addressed almost everything and left couple of qs for the designers for the bits I wasn't sure about, could you take another look?

britneywwc commented 1 month ago

Just one more thing, there should be some padding around the card here Screenshot 2024-08-22 at 2 03 05 PM

mtruj013 commented 1 month ago

@britneywwc it has padding already which is provided by the p-card--overlay class image

It looks like the figma calls for an additional .5 rem though. I can update, but really it sounds like the card component should be officially upstreamed on Vanilla's side as every version we build of this card will need the additional custom style. Issue here