Add is-required label to required fields

britneywwc commented 2 months ago

Done

Add "is-required" class to required fields for /data/mongodb#get-in-touch and /data/kafka#get-in-touch contact forms
The Jira issue reports a "Not Provided" payload for the required fields, this could not be replicated locally so this PR should explicitly tell users to fill up the forms with the required labels

QA

Go to /data/mongodb#get-in-touch and /data/kafka#get-in-touch
See that the contact fields have required * on the labels

Issue / Card

Fixes WD-14682

Screenshots

[if relevant, include a screenshot]

webteam-app commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (6ea4949) to head (9a6e5ec). Report is 172 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1365 +/- ## ========================================== - Coverage 72.48% 71.86% -0.62% ========================================== Files 13 14 +1 Lines 1072 1102 +30 ========================================== + Hits 777 792 +15 - Misses 295 310 +15 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.86% <ø> (-0.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

petesfrench commented 2 months ago

For /data/kafka#get-in-touch the 'phone number' field isn't actually required in Marketo https://na-sjg.marketodesigner.com/m#FOP5522. I don't know if this intentional or not

petesfrench commented 2 months ago

and /data/mongodb#get-in-touch for 'job title' and 'company name' are not required https://na-sjg.marketodesigner.com/m#FOP4903 I am not sure if we should follow Marketo or the copydoc (which I haven't found)

canonical / canonical.com