canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

feat: Build /what-is-postgresql page #1368

Closed petesfrench closed 1 week ago

petesfrench commented 2 weeks ago

Done

Flyby

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-13768

webteam-app commented 2 weeks ago

Demo

Jenkins

demos.haus

petesfrench commented 2 weeks ago

@mattea-turic This is ready for review, just waiting on some the assets

lizzochek commented 2 weeks ago

Was it agreed to remove this image or are we waiting for it? Screenshot 2024-09-12 at 14 12 33

lizzochek commented 2 weeks ago

Please get design approved and image added and ping me for another review in case of any changes

mattea-turic commented 2 weeks ago

This was mb as I did have it like that in the design, but could you remove the two 24px of padding so that only the 64px remains?

Screenshot 2024-09-12 at 14 27 48

And could you pls use the same styling for this section:

Screenshot 2024-09-12 at 14 42 54

As you did for this section:

Screenshot 2024-09-12 at 14 43 32

Currently, the HOCs have some deprecated items so iirc I was swapping the layers in that first section to use from the updated library. But I suppose I forgot to do it for the second section which has caused inconsistency between them now. So, I think I'll avoid messing with the layers of the HOCs to avoid this in the future, esp. since there'll ofc be updates in the future

petesfrench commented 1 week ago

@mattea-turic Can you take another look here. I have upgraded the Vanilla version. I also applied some minor changes to https://canonical-com-1368.demos.haus/core/features/ota-updates

mattea-turic commented 1 week ago

as per my comment in MM, it looks good and I'll design +1 pending the change(s)