WD-13515 Dev Create /openstack/architecture

immortalcodes commented 2 weeks ago

Done

Created /openstack/architecture /openstack page is yet to be made

QA

Check out this feature branch
Run the site using the command ./run serve
View the site locally in your web browser at: http://0.0.0.0:8002/
Run through the following QA steps
Run through checks for new pages.
Design
Copydoc
Demo

Issue / Card

Fixes # WD-13515

Screenshots

[if relevant, include a screenshot]

webteam-app commented 2 weeks ago

demos.haus

mattea-turic commented 2 weeks ago

I uploaded the correct image to go here, so pls replace

Image here should be centred more so that there is spacing at the top. Added to assets server.

Also there was a caption added here that Lyubo recommended, but is not in copydoc. I'll ping Sophie to see what she thinks, but for now it's good. Might just come as a copy update later on.

And a v small thing, to try not leave text orphans, so as you can see in the figma there's breakpoint after "get started". It would probably work well to also have it after "...with", but either way if this can be amended pls

All else is good :)

mattea-turic commented 2 weeks ago

This image should stretch over 12 col, iirc I've got it as cinematic aspect ratio on the figma and exported it like that too, so it should work. Otherwise, lmk, and I'll do some more re-exporting lol

It's good on smaller screen sizes tho!

Lastly, there appears to be a little too much padding after the last list item, so maybe drop the shallow padding that follows the whole comp

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature-openstack@577e7bb). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature-openstack #1369 +/- ## ==================================================== Coverage ? 71.86% ==================================================== Files ? 14 Lines ? 1102 Branches ? 0 ==================================================== Hits ? 792 Misses ? 310 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1369/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.86% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattea-turic commented 2 weeks ago

@immortalcodes all is good, aside from CTAs now seem to not have any padding between themselves and their partner hrs. I'll +1, though, as presumably this is a quick-fix

canonical / canonical.com