canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

WD-14408 - add assets on /solutions/ubuntu-os #1372

Closed lizzochek closed 1 month ago

lizzochek commented 2 months ago

Done

Added assets to the "Everywhere for everyone" section as per figma

QA

Issue / Card

WD-14408

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (6ea4949) to head (185a02f). Report is 189 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1372 +/- ## ========================================== - Coverage 72.48% 71.86% -0.62% ========================================== Files 13 14 +1 Lines 1072 1102 +30 ========================================== + Hits 777 792 +15 - Misses 295 310 +15 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1372/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `71.86% <ø> (-0.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattea-turic commented 1 month ago

only comment I have is that the images here aren't the same height

Screenshot 2024-09-17 at 09 21 39 Screenshot 2024-09-17 at 09 22 43

Lmk if I can help if it's an assets thing, but I'm using the comp just straight from the figma library so they should be correct aspect ratio

petesfrench commented 1 month ago

@mattea-turic wouldn't this be a good candidate for the new equal-row-height--wrap variant?