Closed lizzochek closed 1 month ago
Hi, thanks for the PR.
If we are adding p-rule
to all the hr
tags then there are several that either needs to be closed or need to be added with the class.
You can find all those that miss the class using regex <hr(?!.*\b(p-rule|p-rule--muted)\b)[^>]*>
This still might not be exhaustive.
@lizzochek I also wanted to ask you. For previous <hr />
tags (without any classes) you added either p-rule
or p-rule--muted
. What was the logic behind deciding which class name to add?
If the hr is on top of the section, it’s p-rule, others are muted
@lizzochek p-rule--highlight
when placed above cards like these need u-no-margin--bottom
to retain the original design. I thought I'd already fixed this for the cards, but I guess I only found the ones that were using the overlay 😩
Done
Updated classes on hr elements
QA
Issue / Card
WD-14939