Closed mtruj013 closed 1 month ago
Nice work @mtruj013. Just a couple of things I noticed:
--wrap
the equal height pattern:
or even better, make this a custom small-2, medium-2, large-4 col layout. The above sugggestion fixes the medium breakpoint, but the logos are still too large on small screens
col-small-2
instead of col-small-1
?<div class="col-3 col-medium-2 col-small-2 p-section--shallow">
<a href="https://charmed-kubeflow.io/" aria-label="Kubeflow">
<div class="p-image-container is-highlighted">
<div class=" lazyloaded" data-noscript="">
<img src="https://res.cloudinary.com/canonical/image/fetch/f_auto,q_auto,fl_sanitize,w_568,h_321/https://assets.ubuntu.com/v1/15d9633b-kubeflow.png" srcset="https://res.cloudinary.com/canonical/image/fetch/f_auto,q_auto,fl_sanitize,w_1136,h_642/https://assets.ubuntu.com/v1/15d9633b-kubeflow.png 2x" alt="" width="568" height="321" loading="lazy" class="p-image-container__image">
</div>
</div>
<p>Learn more ›</p>
</a>
</div>
@lyubomir-popov I noticed the ™ character looks too bold in the H1, it doesn't seem to have the same font weight. I checked in the inspector, and I think that's because the character is not part of variable Ubuntu Sans (at least the version on the website/Vanilla), and using instead the fallback non-variable font (and hence not at a font-width of 550):
Maybe something to check?
@juanruitina done! Could you have another look? Also, what do you think about the placeholder text?
Done
secondary-navigation.yaml
for theseQA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-14286