Closed lizzochek closed 2 weeks ago
<br>
after "innovators" in the second section header
<br>
after "amazing" in the third section header
should be deep padding top and bottom for that section too
there shouldn't be shallow padding here, just before the link:
<br>
after "collaboration" in the paragraph text of the "Canonical values" section
a 50/50 text section isn't used for the "Product portfolio" section, so maybe add the paragraph as a section below like in the figma:
In "Your trusted partners..." section, the text to the right should have "Our collaborative..." as a separate paragraph
The first two quotes should also have more spacing as in the figma, where the quote person's title uses "default margin" i.e. an extra 24px
In the figma, there's no bottom padding for this section:
There also should be 8px spacing between the map and caption text
In the figma, for the last section, there are no lines above the links, but I think that's not intentional so keep as is, but I'll just cc @lyubomir-popov to double-check
Looks really nice :)
I'll +1 as these are v minor things and are just small changes that I must've missed before:
Thanks for this! Everything on the page looks good to me, but it's missing from the meganav. Could you please add 'About our company' under Company --> Explore Canonical as per this document: https://docs.google.com/document/d/1Y0dxbuar0UAPSCfILtP7fsEX-83yDh7Ha637FA9Wbik/edit?tab=t.0. Thanks!
Reviewing this by @eliman11's request.
One question, why does this live under /company/about, instead of just /company? The copy doc specified URL should be just /company and is correctly saved in that folder; this makes more sense to me. On top of that, there would be nothing in /company, which would not be great. I'd also suggest to drop the breadcrumbs, they are not useful right now given there's no other pages right now under company, @mattea-turic would you agree?
Some other minor feedback:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.73%. Comparing base (
efbbec3
) to head (d0dae39
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Done
Add new /company/about page
QA
Issue / Card
WD-15274