canonical / canonical.com

Repository for the new version of canonical.com
Other
34 stars 71 forks source link

WD-15274 - company/about new page #1407

Closed lizzochek closed 2 weeks ago

lizzochek commented 3 weeks ago

Done

Add new /company/about page

QA

Issue / Card

WD-15274

webteam-app commented 3 weeks ago

Demo

Jenkins

demos.haus

mattea-turic commented 3 weeks ago
mattea-turic commented 3 weeks ago

Looks really nice :)

I'll +1 as these are v minor things and are just small changes that I must've missed before:

eliman11 commented 3 weeks ago

Thanks for this! Everything on the page looks good to me, but it's missing from the meganav. Could you please add 'About our company' under Company --> Explore Canonical as per this document: https://docs.google.com/document/d/1Y0dxbuar0UAPSCfILtP7fsEX-83yDh7Ha637FA9Wbik/edit?tab=t.0. Thanks!

juanruitina commented 3 weeks ago

Reviewing this by @eliman11's request.

One question, why does this live under /company/about, instead of just /company? The copy doc specified URL should be just /company and is correctly saved in that folder; this makes more sense to me. On top of that, there would be nothing in /company, which would not be great. I'd also suggest to drop the breadcrumbs, they are not useful right now given there's no other pages right now under company, @mattea-turic would you agree?

Some other minor feedback:

Screenshot 2024-10-25 at 14 40 12

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.73%. Comparing base (efbbec3) to head (d0dae39). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1407 +/- ## ======================================= Coverage 69.73% 69.73% ======================================= Files 15 15 Lines 1229 1229 ======================================= Hits 857 857 Misses 372 372 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1407/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1407/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `69.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.