search

canonical / canonicalwebteam.blog

2 stars 11 forks source link

Doesn't take in to account having a newsletter signup card #115

Open Lukewh opened 5 years ago

Lukewh commented 5 years ago

The third item on https://snapcraft.io/blog is replaced by the newsletter sign up form. The blog module should be able to adjust it's offsets to accomodate an extra item as having a newsletter signup is a common pattern (https://ubuntu.com/blog), currently it simply replaces a blog post!?

See for the messy way I implemented it in snapcraft: https://github.com/canonical-web-and-design/snapcraft.io/pull/2119/files#diff-4e6fc427b5a0fb3861c0230dcb245caeL46

Lukewh commented 5 years ago

This is also now affecting jaas.ai

jpmartinspt commented 4 years ago

You can now configure the number of articles you want to pull per page. That should solve this issue, unless we only want tho show the signup card in the first page.

tbille commented 4 years ago

This seems to be fixed.

Lukewh commented 4 years ago

If the solution is "Have a newsletter signup form on every page" this isn't fixed.

solazio commented 4 years ago

@tbille @jpmartinspt this is still an issue on snapcraft.io and ubuntu.com (maybe on others as well). The last post on the first page is showed as the first post on the second page.

carkod commented 2 years ago

it's been almost 2 years. @Lukewh @jkfran , do guys still see this issue?

Lukewh commented 2 years ago

@carkod, yeath this is still an issue. snapcraft is missing "KDE snaps performance revving up":

Snapcraft.io with newsletter sign up: image

Ubuntu.com without: image