Closed bartaz closed 2 years ago
@jkfran Are items without the level turned into empty navigation groups by the module?
@jkfran Are items without the level turned into empty navigation groups by the module?
Yes, that's the current behaviour. empty level = level 0: https://github.com/canonical-web-and-design/canonicalwebteam.discourse/blob/c6eaf99404e02aaade9f77255246d40e292e061d/canonicalwebteam/discourse/parsers/docs.py#L385-L387
So how they should be hidden? In the template?
Ah, found that in juju.is template, but it wasn't used in other templates:
{% if not nav_group.hidden %}
I guess we need it in the default template to make hidden pages work as expected.
Fixed in multipass via https://github.com/canonical-web-and-design/multipass.run/pull/256 but we need to update the default template documented in this project to reflect that as well.
The demo looks good. Thanks!
In multipass after adding some hidden pages with no level the side navigation started showing a line, which is a result of many empty lists added to the navigation:
Part of the config:
https://discourse.ubuntu.com/t/multipass-documentation/8294