Replace emdash with -- in topic paths to be url compatible #145

edlerd commented 2 years ago

Signed-off-by: David Edler david.edler@canonical.com

Fixes #145

petesfrench commented 2 years ago

@jkfran Do you know how I can QA this?

jkfran commented 2 years ago

Thank you for this contribution, @edlerd. Could you also increase the version in the setup.py to release a new version?

@jkfran Do you know how I can QA this?

Hey @petesfrench, you need:

Run a project with Discourse, like ubuntu.com docs
Use this version of the module with these changes. To do it, update the requirements.txt file in the project and replace canonicalwebteam.discourse with git+git://github.com/edlerd/canonicalwebteam.discourse@fix-emdash#egg=canonicalwebteam.discourse
Update the index topic on Discourse to have URLs with -- to see what happens. You might need to give this a read https://discourse.canonical.com/t/creating-discourse-based-documentation-pages/159 to understand how the URL mapping works.

edlerd commented 2 years ago

Added the version bump in setup.py to my commit.

canonical / canonicalwebteam.discourse