search

canonical / canonicalwebteam.discourse

GNU Lesser General Public License v3.0
11 stars 16 forks source link

Improve error reporting #147

Closed edlerd closed 2 years ago

edlerd commented 2 years ago

Fixes #139

When a result with no rows and an error message is returned, raise an exception and add a hint, that the API key might be missing.

carkod commented 2 years ago

@edlerd Same thing here, can you bump the discourse version in setup.py?

Or the other thing we could do is merge this PR first and then merge https://github.com/canonical/canonicalwebteam.discourse/pull/146 so we can have the 2 PRs in one version, to avoid triggering so many renovate updates. In which case the rebase should remove the changes of the other PR

edlerd commented 2 years ago

Updated the version to the same as in https://github.com/canonical/canonicalwebteam.discourse/pull/146 They should emit just one version change if merged locally and then pushed.